This repository has been archived by the owner on Oct 17, 2020. It is now read-only.
Search multiple resource in parallel #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arberiii
changed the title
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
=======================================
Coverage 49.88% 49.88%
=======================================
Files 123 123
Lines 2658 2658
Branches 149 149
=======================================
Hits 1326 1326
Misses 1282 1282
Partials 50 50
Continue to review full report at Codecov.
|
magicoder10
changed the title
magicoder10
changed the title
magicoder10
suggested changes
Jun 4, 2020
|
Hi @arberiii , thank you so much for working on this PR! Please include unit test so that we don't accidentally break this feature in the future. |
|
Discussed offline. Will add unit tests in the next PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search Short's resources by starting a goroutine for each resource.
This PR is part of issue #260, as the continuation of #PR 829.
The approach used here is very similar to Rob Pike's talk on Go Concurrency Patterns
Rob Pike.