Turn white-space into a shorthand #32146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#8837962271) for Linux WPT, MacOS, Windows, Android |
|
Test results for linux-wpt-layout-2013 from try job (#8837962271): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (21)
Stable unexpected results (247)
|
|
Test results for linux-wpt-layout-2020 from try job (#8837962271): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (257)
|
|
|
Loirooriol
force-pushed
the
white-space-shorthand
branch
from
d06f05a
to
5542a7f
Compare
Loirooriol
added
T-linux-wpt-2013
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#8840401221) for Linux WPT |
|
Test results for linux-wpt-layout-2013 from try job (#8840401221): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (6)
Stable unexpected results (12)
|
|
Test results for linux-wpt-layout-2020 from try job (#8840401221): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (16)
Stable unexpected results (6)
|
|
|
Loirooriol
added a commit
to Loirooriol/servo
that referenced
this pull request
Apr 26, 2024
This ports servo#31277 (with the changes from servo#32066) into legacy layout. Otherwise, turning white-space into a shorthand (servo#32146) would fail some tests that expect the property to be serializable.
4 tasks
Loirooriol
force-pushed
the
white-space-shorthand
branch
from
5542a7f
to
8320071
Compare
github-actions
bot
removed
the
T-linux-wpt-2013
|
🔨 Triggering try run (#8846913625) for Linux WPT |
|
Test results for linux-wpt-layout-2013 from try job (#8846913625): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (11)
Stable unexpected results (67)
|
|
|
mrobinson
approved these changes
Apr 26, 2024
Loirooriol
force-pushed
the
white-space-shorthand
branch
from
8320071
to
6027fc9
Compare
Loirooriol
added
T-linux-wpt-2013
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#8854647944) for Linux WPT |
Loirooriol
force-pushed
the
white-space-shorthand
branch
from
6027fc9
to
ffd8a16
Compare
|
Test results for linux-wpt-layout-2013 from try job (#8854647944): Flaky unexpected result (10)
Stable unexpected results that are known to be intermittent (12)
Stable unexpected results (2)
|
|
Test results for linux-wpt-layout-2020 from try job (#8854647944): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (19)
|
|
|
|
Adding
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
4 tasks
nicoburns
added
T-linux-wpt-2013
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#8876788835) for Linux WPT |
|
|
Bumps Stylo to servo/stylo#37 `white-space` is split into `white-space-collapse` and `text-wrap-mode`: | white-space | white-space-collapse | text-wrap-mode | | ----------- | -------------------- | -------------- | | normal | collapse | wrap | | nowrap | collapse | nowrap | | pre-wrap | preserve | wrap | | pre | preserve | nowrap | | pre-line | preserve-breaks | wrap | | - | preserve-breaks | nowrap | Note this introduces a combination that wasn't previously possible, but I think the existing logic can handle it well enough. The old `allow_wrap()` is replaced by checking whether `text-wrap-mode` is set to `wrap`. The old `preserve_newlines()` is replaced by checking whether `white-space-collapse` is *not* set to `collapse`. The old `preserve_spaces()` is replaced by checking whether `white-space-collapse` is set to `preserve`.
Loirooriol
force-pushed
the
white-space-shorthand
branch
from
26c1e94
to
f2b6cb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps Stylo to servo/stylo#37
white-spaceis split intowhite-space-collapseandtext-wrap-mode:Note this introduces a combination that wasn't previously possible, but I think the existing logic can handle it well enough.
The old
allow_wrap()is replaced by checking whethertext-wrap-modeis set towrap.The old
preserve_newlines()is replaced by checking whetherwhite-space-collapseis not set tocollapse.The old
preserve_spaces()is replaced by checking whetherwhite-space-collapseis set topreserve../mach build -ddoes not report any errors./mach test-tidydoes not report any errors