-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let legacy layout serialize shorthands in getComputedStyle #32149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ports servo#31277 (with the changes from servo#32066) into legacy layout. Otherwise, turning white-space into a shorthand (servo#32146) would fail some tests that expect the property to be serializable.
github-actions
bot
removed
the
T-linux-wpt-2013
Do a try run of the WPT (legacy layout)
label
Apr 26, 2024
🔨 Triggering try run (#8846876090) for Linux WPT |
Test results for linux-wpt-layout-2013 from try job (#8846876090): Flaky unexpected result (9)
Stable unexpected results that are known to be intermittent (12)
Stable unexpected results (58)
|
|
Loirooriol
added
T-linux-wpt-2013
Do a try run of the WPT (legacy layout)
T-linux-wpt-2020
Do a try run of the WPT
labels
Apr 26, 2024
github-actions
bot
removed
T-linux-wpt-2013
Do a try run of the WPT (legacy layout)
T-linux-wpt-2020
Do a try run of the WPT
labels
Apr 26, 2024
🔨 Triggering try run (#8847706644) for Linux WPT |
Test results for linux-wpt-layout-2013 from try job (#8847706644): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (10)
|
Test results for linux-wpt-layout-2020 from try job (#8847706644): Flaky unexpected result (32)
Stable unexpected results that are known to be intermittent (15)
|
✨ Try run (#8847706644) succeeded. |
mrobinson
approved these changes
Apr 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports #31277 (with the changes from #32066) into legacy layout.
Otherwise, turning white-space into a shorthand (#32146) would fail some tests that expect the property to be serializable.
./mach build -d
does not report any errors./mach test-tidy
does not report any errors