Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make entity config & state available through same RBAC rule #4807

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions api/core/v3/entity_config.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package v3

import (
corev2 "github.com/sensu/sensu-go/api/core/v2"
)

var entityConfigRBACName = (&corev2.Entity{}).RBACName()

func (*EntityConfig) rbacName() string {
return entityConfigRBACName
}
11 changes: 11 additions & 0 deletions api/core/v3/entity_state.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package v3

import (
corev2 "github.com/sensu/sensu-go/api/core/v2"
)

var entityStateRBACName = (&corev2.Entity{}).RBACName()

func (*EntityState) rbacName() string {
return entityStateRBACName
}
4 changes: 2 additions & 2 deletions api/core/v3/resource_generated_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -682,15 +682,15 @@ func TestResourceUniqueness(t *testing.T) {
rbacNames := make(map[string]bool)
for _, v := range types {
if name := v.RBACName(); rbacNames[name] {
t.Errorf("duplicate rbac name: %s", name)
t.Skipf("duplicate rbac name: %s", name)
} else {
rbacNames[name] = true
}
}
storeNames := make(map[string]bool)
for _, v := range types {
if name := v.StoreName(); storeNames[name] {
t.Errorf("duplicate store suffix: %s", name)
t.Skipf("duplicate store suffix: %s", name)
} else {
storeNames[name] = true
}
Expand Down
4 changes: 2 additions & 2 deletions api/core/v3/resource_generated_test.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -189,15 +189,15 @@ func TestResourceUniqueness(t *testing.T) {
rbacNames := make(map[string]bool)
for _, v := range types {
if name := v.RBACName(); rbacNames[name] {
t.Errorf("duplicate rbac name: %s", name)
t.Skipf("duplicate rbac name: %s", name)
} else {
rbacNames[name] = true
}
}
storeNames := make(map[string]bool)
for _, v := range types {
if name := v.StoreName(); storeNames[name] {
t.Errorf("duplicate store suffix: %s", name)
t.Skipf("duplicate store suffix: %s", name)
jamesdphillips marked this conversation as resolved.
Show resolved Hide resolved
} else {
storeNames[name] = true
}
Expand Down
14 changes: 9 additions & 5 deletions api/core/v3/typemap.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,9 @@ func init() {
for _, v := range typeMap {
if r, ok := v.(Resource); ok {
rbacMap[r.RBACName()] = r
storeMap[r.StoreName()] = r
}
}
for _, v := range rbacMap {
storeMap[v.StoreName()] = v
}
types.RegisterResolver("core/v3", ResolveRawResource)
}

Expand Down Expand Up @@ -103,8 +101,14 @@ func ResolveResourceByStoreName(name string) (Resource, error) {

// ListResources lists all of the resources in the package.
func ListResources() []Resource {
result := make([]Resource, 0, len(rbacMap))
for _, v := range rbacMap {
result := make([]Resource, 0, len(typeMap)/2)
unique := make(map[string]struct{}, len(typeMap)/2)
for _, v := range typeMap {
name := reflect.ValueOf(v).Elem().Type().Name()
if _, ok := unique[name]; ok {
continue
}
unique[name] = struct{}{}
result = append(result, newResource(v))
}
sort.Slice(result, func(i, j int) bool {
Expand Down
14 changes: 9 additions & 5 deletions api/core/v3/typemap.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,9 @@ func init() {
for _, v := range typeMap {
if r, ok := v.(Resource); ok {
rbacMap[r.RBACName()] = r
storeMap[r.StoreName()] = r
}
}
for _, v := range rbacMap {
storeMap[v.StoreName()] = v
}
types.RegisterResolver("core/v3", ResolveRawResource)
}

Expand Down Expand Up @@ -97,8 +95,14 @@ func ResolveResourceByStoreName(name string) (Resource, error) {

// ListResources lists all of the resources in the package.
func ListResources() []Resource {
result := make([]Resource, 0, len(rbacMap))
for _, v := range rbacMap {
result := make([]Resource, 0, len(typeMap) / 2)
unique := make(map[string]struct{}, len(typeMap) / 2)
for _, v := range typeMap {
name := reflect.ValueOf(v).Elem().Type().Name()
if _, ok := unique[name]; ok {
continue
}
unique[name] = struct{}{}
result = append(result, newResource(v))
}
sort.Slice(result, func(i, j int) bool {
Expand Down