Make entity config & state available through same RBAC rule #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
echlebek
reviewed
Jul 21, 2022
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
jamesdphillips
added a commit
that referenced
this pull request
Aug 22, 2022
* Expose `EntityConfig` & `EntityState` resources through GraphQL service * Add `Fields()` method to `EntityConfig` & `EntityState` resources so that they implement the `Fielder` interface; allows users to filter with field selectors. * Complication: The core/v3 package previous checked that each resource in the package had a unique `RBACName()`, however, since we don't want distinct names for the config & state resources this proved to be problematic. As such I've disabled the uniqueness tests for the time being. (Same as: #4807) Signed-off-by: James Phillips <jamesdphillips@gmail.com>
c-kruse
pushed a commit
that referenced
this pull request
Sep 29, 2022
* Expose `EntityConfig` & `EntityState` resources through GraphQL service * Add `Fields()` method to `EntityConfig` & `EntityState` resources so that they implement the `Fielder` interface; allows users to filter with field selectors. * Complication: The core/v3 package previous checked that each resource in the package had a unique `RBACName()`, however, since we don't want distinct names for the config & state resources this proved to be problematic. As such I've disabled the uniqueness tests for the time being. (Same as: #4807) Signed-off-by: James Phillips <jamesdphillips@gmail.com> (cherry picked from commit f3bc8f5)
c-kruse
pushed a commit
that referenced
this pull request
Sep 30, 2022
* Expose `EntityConfig` & `EntityState` resources through GraphQL service * Add `Fields()` method to `EntityConfig` & `EntityState` resources so that they implement the `Fielder` interface; allows users to filter with field selectors. * Complication: The core/v3 package previous checked that each resource in the package had a unique `RBACName()`, however, since we don't want distinct names for the config & state resources this proved to be problematic. As such I've disabled the uniqueness tests for the time being. (Same as: #4807) Signed-off-by: James Phillips <jamesdphillips@gmail.com> (cherry picked from commit f3bc8f5)
c-kruse
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Expose `EntityConfig` & `EntityState` resources through GraphQL service * Add `Fields()` method to `EntityConfig` & `EntityState` resources so that they implement the `Fielder` interface; allows users to filter with field selectors. * Complication: The core/v3 package previous checked that each resource in the package had a unique `RBACName()`, however, since we don't want distinct names for the config & state resources this proved to be problematic. As such I've disabled the uniqueness tests for the time being. (Same as: #4807) Signed-off-by: James Phillips <jamesdphillips@gmail.com> (cherry picked from commit f3bc8f5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corev3package machinery produces a test to verify that all the types in the package had a unique RBAC name, and barring any Chesterton fence scenarios, I've skipped these tests for now. The previous behaviour seems overzealous as multiple types with the same RBAC rule seems reasonable to moi.