Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TerminalConsole test_without_start_listening #6224

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add TerminalConsole test_without_start_listening #6224

wants to merge 5 commits into from

Commits on Feb 16, 2024

  1. Add TerminalConsole test_without_start_listening 

    Class variables should always be initialized in the `.__init__()` method but `TerminalConsole.port` is not.  As discussed in:
* scrapy#2702
* scrapy#2892
    @cclauss
    cclauss committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    077bbc1 View commit details
    Browse the repository at this point in the history

  2. with self.assertRaises(NameError):

    @cclauss
    cclauss committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    2d14cec View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. AttributeError: 'TelnetConsole' object has no attribute 'port'

    @cclauss
    cclauss committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    7d03f3f View commit details
    Browse the repository at this point in the history

  2. Update test_extension_telnet.py

    @cclauss
    cclauss committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    ef571a5 View commit details
    Browse the repository at this point in the history

  3. The .start_listening() method should be called but...

    @cclauss
    cclauss committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    cd9b51d View commit details
    Browse the repository at this point in the history