Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TerminalConsole test_without_start_listening #6224

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cclauss
Copy link

@cclauss cclauss commented Feb 16, 2024

Class variables should always be initialized in the .__init__() method but TerminalConsole.port is not. As discussed in:

Class variables should always be initialized in the `.__init__()` method but `TerminalConsole.port` is not.  As discussed in:
* scrapy#2702
* scrapy#2892
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Merging #6224 (cd9b51d) into master (c5fdba9) will increase coverage by 0.01%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6224      +/-   ##
==========================================
+ Coverage   88.59%   88.61%   +0.01%     
==========================================
  Files         161      161              
  Lines       11761    11775      +14     
  Branches     1907     1908       +1     
==========================================
+ Hits        10420    10434      +14     
  Misses       1011     1011              
  Partials      330      330              

see 1 file with indirect coverage changes

@wRAR
Copy link
Member

wRAR commented Feb 16, 2024

Is this a work in progress?

@cclauss
Copy link
Author

cclauss commented Feb 16, 2024

builtins.AttributeError: 'TelnetConsole' object has no attribute 'port'

@cclauss cclauss restored the patch-1 branch February 17, 2024 12:37
@cclauss cclauss reopened this Feb 17, 2024
@cclauss cclauss marked this pull request as draft February 17, 2024 12:37
@cclauss cclauss marked this pull request as ready for review February 17, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants