improve the log configuration with using RotatingFileHandler. #4844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4844 +/- ##
==========================================
- Coverage 87.85% 87.82% -0.04%
==========================================
Files 160 160
Lines 9735 9740 +5
Branches 1437 1438 +1
==========================================
+ Hits 8553 8554 +1
- Misses 925 928 +3
- Partials 257 258 +1
|
|
@Gallaecio hi, there is a check , codecov/patch, not successful, is it must be successful then the request can be merged? |
Gallaecio
reviewed
Oct 25, 2020
Comment on lines
4
to
6
| from logging.config import dictConfig | ||
|
|
||
| from logging.handlers import RotatingFileHandler | ||
| from twisted.python import log as twisted_log |
There was a problem hiding this comment.
💄 Please, keep the empty line separating imports from the standard library from imports from third-party libraries.
| @@ -122,7 +122,14 @@ def _get_handler(settings): | |||
| filename = settings.get('LOG_FILE') | |||
| if filename: | |||
| encoding = settings.get('LOG_ENCODING') | |||
| handler = logging.FileHandler(filename, encoding=encoding) | |||
| if settings.get("LOG_ROTATING") is True: | |||
There was a problem hiding this comment.
Suggested change
| if settings.get("LOG_ROTATING") is True: | |
| if settings.getbool("LOG_ROTATING") is True: |
This makes it possible to set the setting from the command line, where every value is a string.
| @@ -154,7 +157,11 @@ These settings can be used to configure the logging: | |||
| The first couple of settings define a destination for log messages. If | |||
| :setting:`LOG_FILE` is set, messages sent through the root logger will be | |||
| redirected to a file named :setting:`LOG_FILE` with encoding | |||
| :setting:`LOG_ENCODING`. If unset and :setting:`LOG_ENABLED` is ``True``, log | |||
| :setting:`LOG_ENCODING`. If :setting:`LOG_FILE` is set and | |||
| :setting:`LOG_ROTATING` is ```True```, the file named | |||
There was a problem hiding this comment.
💄
Suggested change
| :setting:`LOG_ROTATING` is ```True```, the file named | |
| :setting:`LOG_ROTATING` is ``True``, the file named |
|
@Gallaecio I made a new PR to pick this up since this is stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new options about log so that users can set the size and backup count of log file.
Resolves #3628