Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for log rotation per issue #3628 #6155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DinkyC
Copy link

@DinkyC DinkyC commented Nov 25, 2023

Added functionality and documentation for time based log rotation per issue #3628.

Fixes #3628, closes #4465, closes #4844, closes #5815.

tests/sample.log Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Merging #6155 (11912fc) into master (fa690fb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6155   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files         159      159           
  Lines       11582    11585    +3     
  Branches     1885     1886    +1     
=======================================
+ Hits        10261    10264    +3     
  Misses        994      994           
  Partials      327      327           
Files Coverage Δ
scrapy/utils/log.py 92.07% <100.00%> (+0.24%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crawler logs are cut by day
2 participants