Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractNavitiaProvider: Remove all providers based on Navitia. #402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schildbach
Copy link
Owner

I propose to remove all providers based on Navitia. They have been causing many runtime errors since years, without anyone working on them. If we don't find a responsible maintainer for the Navitia API (mainly AbstractNavitiaProvider), we I think we'd rather remove these classes.

@schildbach
Copy link
Owner Author

Pinging @aelkhour and @grote as you're listed as authors.

@grote
Copy link
Contributor

grote commented Sep 21, 2021

Also pinging @ialokim and @prhod about the removal of Navitia from PTE.

@ialokim
Copy link
Contributor

ialokim commented Sep 21, 2021

I think it's less the PTE's implementation of AbstractNavitiaProvider that leads to problems, but instead the data on the Navitia server which is not always up-to-date or gets some updates changing IDs or such. I think we can not do much on PTE's side on this, apart from perhaps implementing a slightly better error handling.

It would be really a shame if all those providers were removed from PTE. I would be okay maintaining them to the extend that is possible without having access to the data source (Navitia API) itself.

@aelkhour
Copy link
Contributor

@schildbach I don't have the bandwidth to maintain this provider. Although I am the instigator of this and had a lot of fun adding it, I understand your decision if there are no maintainers.

@Altonss
Copy link

Altonss commented Oct 14, 2021

The removal of all providers based on Navitia would be a big loss :( What specific errors/problems are encountered with Navitia? I would be happy to help working those out :)

@prhod
Copy link

prhod commented Oct 14, 2021

Thanks @grote for poking me, seems i've missed a few messages, sorry about that. I've relayed the message to the Navitia dev team, I hope a solution can be found on this.

@stifoon
Copy link

stifoon commented Oct 14, 2021

Hi all,
Here is some reflexions i had this evening

  • Maybe we could post a message to get some help from the navitia forum. But i can't understand what kind of errors we are talking about, and what kind of contributions we need on PTE
  • If errors occurs mostly on few providers (seems to be "coverages" in Navitia API), maybe could you delete only these providers ?
  • @grote told us about some id change problems. As it comes from GTFS providers, you may known some good practise : how do you manage this kind of change with the other providers ? Maybe we could do some improvement in Navitia API on that point ?

@schildbach
Copy link
Owner Author

schildbach commented Mar 14, 2022

The removal of all providers based on Navitia would be a big loss :( What specific errors/problems are encountered with Navitia? I would be happy to help working those out :)

Sorry for getting back to your question only now.

I tagged most of the open issues with the tag "navitia".

@schildbach
Copy link
Owner Author

There is one more problem with Navitia: their API limit for free accounts seems to be exceeded by Öffi now and then. Not sure how other apps like Transportr do, but for Öffi this is quite discouraging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants