Add Netherlands provider #510
Conversation
|
|
||
| @Test | ||
| public void nearbyStationsStation() throws Exception { | ||
| nearbyStationsStation("stop_point:OAM:2323791"); |
There was a problem hiding this comment.
I saw some comment in this existing file: https://github.com/schildbach/public-transport-enabler/blob/master/test/de/schildbach/pte/live/FranceNorthEastProviderLiveTest.java#L51
There, it says:
// station to find other stations around
// look in NTFS file for a stop_id (that contains "SP") and apend to "stop_point:"
In the Netherlands NTFS file, file object_codes.txt I found this line:
stop_point,OAM:2345074,source,2345074
I'm not sure if I used the right formatting here.
|
|
||
| @Test | ||
| public void queryDeparturesEquivsFalse() throws Exception { | ||
| queryDeparturesEquivsFalse("stop_point:OAM:2323791"); |
There was a problem hiding this comment.
Here I used the same as nearbyStationsStation, like in the FranceNorthEastProvider file
|
|
||
| @Test | ||
| public void queryDeparturesStopArea() throws Exception { | ||
| queryDeparturesStopArea("stop_area:OAM:stoparea:390116"); |
There was a problem hiding this comment.
From the NTFS file I used the line
stop_area,OAM:stoparea:390116,source,stoparea:390116
Not sure if I formatted it correctly.
|
Hi @schildbach, do you perhaps have a chance to take a look at this PR? |
|
Thanks for your contribution! I'm hesitant to merge this, because it is based on Navitia, and support for Navitia is in bad shape in general. We need someone to take the role of maintaining AbstractNavitiaProvider. As a consequence, I'm about to remove all Navitia based providers. See #402. |
schildbach
added
the
navitia
I followed the instructions here to add the Netherlands provider (https://navitia.opendatasoft.com/explore/dataset/nl/information/).
I''ll add a few comments where I was unsure about what exactly to add.
Hope this is useful, please let me know if anything needs to be fixed.