Restore image
argument to Load10X_Spatial()
for seurat5
#7837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
image
argument appears to have been removed fromLoad10X_Spatial()
upstream from theseurat5
development branch in a merge commit here. This PR fixes #7560 and resolves #7608 which note the following issues:is.null(x = image)
evaluates toFALSE
, raising an inheritance error from:if (!inherits(x = image, what = "VisiumV1"))
This might be due to a namespace conflict with the standard generic
graphics::image
. Whenimage
is not set toNULL
in the function scope, the check evaluates toFALSE
given an existing method:image
(e.g., with a call toRead10X_Image
) raises an unused argument errorimage
argument is dot-forwarded toRead10X_h5()
, which lacks the defined argumentNote
I am submitting this PR directly to the
seurat5
branch from an up-to-date fork instead of thedevelop
branch, given the issue appears to be localized to the v5 development branch. Hope that is alright!