support colliding CSS filter effects functions #467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSS filter effects [0] define several functions (invert, grayscale,
opacity, saturation) that collide with the names of built-in Sass
functions. Overload these functions with a no-op when the filter effects
function signature is discovered. This is compatible with Ruby Sass.
For example, calling `invert` with a color will return an inverted color
as before:
color: invert(sass#333) => color: #cccccc
But calling `invert` with a percentage will pass through the function
call unharmed.
filter: invert(30%) => filter: invert(30%)
filter: invert(.03) => filter: invert(.03)
Fixes sass#151.
[0]: http://www.w3.org/TR/filter-effects/
|
Perfect! Thanks 👍 |
HamptonMakes
pushed a commit
to sass/sass-spec
that referenced
this pull request
Oct 5, 2014
|
This seems to conflict with the work @iamcarrico did on his patch #456, which only focused on invert(). This does address alpha() and grayscale() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS filter effects (0) define several functions (invert, grayscale,
opacity, saturation) that collide with the names of built-in Sass
functions. Overload these functions with a no-op when the filter effects
function signature is discovered. This is compatible with Ruby Sass.
For example, calling
invertwith a color will return an inverted coloras before:
But calling
invertwith a percentage will pass through the functioncall unharmed.
Fixes #151.
(0): http://www.w3.org/TR/filter-effects/