add tests for CSS native filter functions #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests to verify that attempts to use native CSS filter functions, like `grayscale(20%)`, are properly passed through to CSS unchanged, rather than interpreted as the Sass function `grayscale` that operates on colors. Fixes compatibility with Ruby Sass.
|
I'm going to merge this in, but I will move the test into the todo directory for now if it doesn't pass in libsass. |
michaek
added a commit
that referenced
this pull request
Sep 26, 2014
add tests for CSS native filter functions
|
@michaek thanks! These'll actually pass if you merge in my sister PR sass/libsass#467. Cheers! |
|
I don't have the power to commit to sass/libsass. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to verify that attempts to use native CSS filter functions,
like
grayscale(20%), are properly passed through to CSS unchanged,rather than interpreted as the Sass function
grayscalethat operateson colors.
Fixes compatibility with Ruby Sass.
Original issue reported in sass/libsass#151. These tests pass with
sass/libsass#467.