Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup configure nits #27331

Closed

Conversation

mstewartgallus
Copy link
Contributor

So, I'm doing more things to cleanup the configure script.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned pcwalton Jul 27, 2015
@bors
Copy link
Contributor

bors commented Jul 28, 2015

☔ The latest upstream changes (presumably #27250) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Jul 28, 2015

☔ The latest upstream changes (presumably #27173) made this pull request unmergeable. Please resolve the merge conflicts.

@mstewartgallus
Copy link
Contributor Author

I did make this ready merge and change the parts talked about.

@brson
Copy link
Contributor

brson commented Aug 12, 2015

I haven't seen this PR before. Will review tomorrow.

@bors
Copy link
Contributor

bors commented Aug 12, 2015

☔ The latest upstream changes (presumably #27630) made this pull request unmergeable. Please resolve the merge conflicts.

@brson
Copy link
Contributor

brson commented Aug 14, 2015

r=me I'm sorry I forgot about this.

@tamird
Copy link
Contributor

tamird commented Sep 24, 2015

needs a rebase

@alexcrichton
Copy link
Member

Closing due to inactivity, but feel free to resend with a rebase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants