Fix false positive in empty_line_after_outer_attribute #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`empty_line_after_outer_attribute` produced a false positive warning when deriving `Copy` and/or `Clone` for an item. It looks like the second point in [this comment][that_comment] is related, as the attribute that causes the false positive has a path of `rustc_copy_clone_marker`. Fixes rust-lang#2475 [that_comment]: rust-lang/rust#35900 (comment)
|
Whee! I love tiny fixes that close multiple issues |
|
I didn't expect this lint to cause so many false positives :D I plan to be at the rust learners meetup in Berlin tomorrow and want run the lint on some other, bigger repos. |
phansch
deleted the
false_positive_empty_line_after_outer_attr_with_enum
branch
|
🎉 see you there |
|
It was great being there! Looks like this also fixed #2453 👍 |
This was referenced Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
empty_line_after_outer_attributeproduced a false positive warning whenderiving
Copyand/orClonefor an item.It looks like the second point in this comment is related,
as the attribute that causes the false positive has a path of
rustc_copy_clone_marker.Checking for an empty
TokenStreamon the attribute gets around these attributes.Fixes #2475, #2517