Merge pull request #2577 from phansch/false_positive_empty_line_after…

…_outer_attr_with_enum Fix false positive in empty_line_after_outer_attribute
rust-lang · Mar 26, 2018 · f7c4bb6 · f7c4bb6
2 parents eafd090 + 034c81b
commit f7c4bb6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/clippy_lints/src/attrs.rs b/clippy_lints/src/attrs.rs
@@ -267,7 +267,7 @@ fn check_attrs(cx: &LateContext, span: Span, name: &Name, attrs: &[Attribute]) {
             return;
         }
         if attr.style == AttrStyle::Outer {
-            if !is_present_in_source(cx, attr.span) {
+            if attr.tokens.is_empty() || !is_present_in_source(cx, attr.span) {
                 return;
             }
 

diff --git a/tests/ui/empty_line_after_outer_attribute.rs b/tests/ui/empty_line_after_outer_attribute.rs
@@ -67,4 +67,16 @@ pub fn function() -> bool {
     true
 }
 
+// This should not produce a warning
+#[derive(Clone, Copy)]
+pub enum FooFighter {
+    Bar1,
+
+    Bar2,
+
+    Bar3,
+
+    Bar4
+}
+
 fn main() { }