internal: Fix lsp_ext field name for RecursiveMemoryLayoutNode#21986
Merged
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom Apr 9, 2026
Merged
internal: Fix lsp_ext field name for RecursiveMemoryLayoutNode#21986ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
Conversation
Due `editors/code/src/commands.ts` uses inline HTML, so this error pass to type check
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
approved these changes
Apr 9, 2026
Contributor
|
I don't like the usage of inner HTML including JavaScript, it's better to remove it. |
rustbot
removed
the
S-waiting-on-review
Member
Author
I am not familiar with HTML and JavaScript |
Contributor
|
Fine, it was not directed at you specifically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due
editors/code/src/commands.tsuses inline HTML, so this error pass to type check