fix: Fix SyntaxEditor upmapping of nodes with mapped ancestor that aren't mapped themselves#21962
Merged
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom Apr 6, 2026
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
changed the title
…mapped themselves There is no point to expect a connection between the mapped ancestor and the unmapped child.
ChayimFriedman2
force-pushed
the
fix-syntaxeditor
branch
from
2489b89 to
3cbcf89
Compare
Contributor
Author
|
Given the approval from @Shourya742 here and @DropDemBits on Zulip, I'll merge this. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no point to expect a connection between the mapped ancestor and the unmapped child.
See #t-compiler/rust-analyzer > Mapping in SyntaxEditor.