fix: add semicolon for postfix format unit like snippets#21955
Merged
A4-Tacks merged 2 commits intorust-lang:masterfrom Apr 6, 2026
Merged
fix: add semicolon for postfix format unit like snippets#21955A4-Tacks merged 2 commits intorust-lang:masterfrom
A4-Tacks merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Example
---
```rust
fn main() {
"{ 2+2 } { SomeStruct { val: 1, other: 32 } :?}".println
}
```
**Before this PR**
```rust
fn main() {
println!("{} {:?}", 2 + 2, SomeStruct { val: 1, other: 32 })
}
```
**After this PR**
```rust
fn main() {
println!("{} {:?}", 2 + 2, SomeStruct { val: 1, other: 32 });
}
```
A4-Tacks
force-pushed
the
postfix-format-semi
branch
from
eba3543 to
42cffd3
Compare
ChayimFriedman2
approved these changes
Apr 5, 2026
| ("logw", "log::warn!"), | ||
| ("loge", "log::error!"), | ||
| ]; | ||
| static HAS_VALUE: &[&str] = &["format"]; |
Contributor
There was a problem hiding this comment.
Name is a bit unclear. Perhaps FORMAT_SNIPPET_RETURNS_UNIT?
Member
Author
There was a problem hiding this comment.
Since it's not public, I think SNIPPET_RETURNS_NON_UNIT is enough
| && let Some(literal_text) = ast::String::cast(literal.token()) | ||
| { | ||
| add_format_like_completions(acc, ctx, &dot_receiver_including_refs, cap, &literal_text); | ||
| add_format_like_completions(acc, ctx, dot_receiver, cap, &literal_text, semi); |
Contributor
There was a problem hiding this comment.
We could also handle match arms here and insert a comma.
Member
Author
There was a problem hiding this comment.
I will test this in the new PR
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example
Before this PR
After this PR