Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracepoint for publish/subscribe serialized_message #748

Merged
merged 3 commits into from Apr 1, 2024

Conversation

h-suzuki-isp
Copy link
Contributor

Please, refer to ros2/rclcpp#2448 .
I have added the following trace points.

  • __rmw_publish_serialized_message()
    • tracepoint : rmw_publish
  • _take_serialized_message()
    • tracepoint : rmw_take

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fujitatomoya
Copy link
Collaborator

@mjcarroll can you review and run CI?

@christophebedard
Copy link
Member

Can you rebase this on rolling? There were some changes (like #746 + ros2/ros2#1530) that require the latest commit.

Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
@h-suzuki-isp
Copy link
Contributor Author

Can you rebase this on rolling? There were some changes (like #746 + ros2/ros2#1530) that require the latest commit.

@christophebedard Yes, I rebased.

@fujitatomoya fujitatomoya merged commit c0dab2d into ros2:rolling Apr 1, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants