Fix deprecated import collections #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Afraid that no one continues to support this project... |
gabor-boros
previously approved these changes
Mar 5, 2021
|
👍🏻 @gabor-boros :) |
|
This was resolved in 2 to 3 branch : #187 |
tirkarthi
reviewed
Mar 7, 2021
metal3d
force-pushed
the
fix-252-abc-import
branch
from
4a80a8f
to
71112d0
Compare
Replace import collections to import collection.abc for Python >= 3.3 See issue rethinkdb#252
metal3d
force-pushed
the
fix-252-abc-import
branch
from
71112d0
to
13a4107
Compare
gabor-boros
approved these changes
Sep 29, 2021
|
@metal3d Thank you for the contribution! Although a bit late, but approved and merged! |
|
👍🏻 no problem |
|
@gabor-boros Now that 3.10 has been released will you cut a new release, please? It would be much appreciated, thank you <3 |
|
@Inveracity a massive refactor coming soon. I'll open the whip PR probably by Wednesday |
|
Heya @gabor-boros I'm curious if there has been any progress on the above? |
|
@Inveracity Yes, we had some progress, though we are not ready yet with the changes. Feel free to join to Discord or slack and ping me. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace import collections to import collection.abc for Python >= 3.3
See issue #252
Reason for the change
See #252 for
collectionsdeprecationDescription
collectionsis deprecated, we need to importcollections.abcNote that
blackmade some code fixes (indentation, import order...)Checklist
References
Anything else related to the change e.g. documentations, RFCs, etc.