Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeprecationWarning with pytest #252

Open
metal3d opened this issue Mar 1, 2021 · 0 comments
Open

DeprecationWarning with pytest #252

metal3d opened this issue Mar 1, 2021 · 0 comments
Labels
bug Something isn't working not qualified The issue is not checked yet by the owners

Comments

@metal3d
Copy link
Contributor

metal3d commented Mar 1, 2021 •
edited

Describe the bug
Running tests for one project, I see:

../../.local/share/virtualenvs/rethinkmodel-WGhjQTXi/lib/python3.9/site-packages/rethinkdb/ast.py:87
  /home/metal3d/.local/share/virtualenvs/rethinkmodel-WGhjQTXi/lib/python3.9/site-packages/rethinkdb/ast.py:87: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
    elif isinstance(val, collections.Callable):

../../.local/share/virtualenvs/rethinkmodel-WGhjQTXi/lib/python3.9/site-packages/rethinkdb/ast.py:108
  /home/metal3d/.local/share/virtualenvs/rethinkmodel-WGhjQTXi/lib/python3.9/site-packages/rethinkdb/ast.py:108: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
    elif isinstance(val, collections.Mapping):

rethinkmodel/tests/test_generic.py::GenericTest::test_create
  /home/metal3d/.local/share/virtualenvs/rethinkmodel-WGhjQTXi/lib/python3.9/site-packages/rethinkdb/ast.py:115: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
    elif isinstance(val, collections.Iterable):

Note the message: with Python 3.10, the module will stop working. I made a Pull Request to fix, see #253

To Reproduce
Steps to reproduce the behavior:

  1. Launch pytest on any project using rethinkdb

Expected behavior
No warning...

System info

  • OS: Linux Fedora 33
@metal3d metal3d added bug Something isn't working not qualified The issue is not checked yet by the owners labels Mar 1, 2021
metal3d added a commit to metal3d/rethinkdb-python that referenced this issue Mar 1, 2021
@metal3d
Fix deprecated import collections
c78d3e1 
See issue rethinkdb#252
metal3d added a commit to metal3d/rethinkdb-python that referenced this issue Mar 1, 2021
@metal3d
Fix deprecated import collections
4a80a8f 
Replace import collections to import collection.abc for Python >= 3.3

See issue rethinkdb#252
@metal3d metal3d mentioned this issue Mar 1, 2021
Merged
1 task
metal3d added a commit to metal3d/rethinkdb-python that referenced this issue Mar 7, 2021
@metal3d
Fix deprecated import collections
71112d0 
Replace import collections to import collection.abc for Python >= 3.3

See issue rethinkdb#252
metal3d added a commit to metal3d/rethinkdb-python that referenced this issue Mar 7, 2021
@metal3d
Fix deprecated import collections
13a4107 
Replace import collections to import collection.abc for Python >= 3.3

See issue rethinkdb#252
gabor-boros pushed a commit that referenced this issue Sep 29, 2021
@metal3d
Fix deprecated import collections (#253)
424cff7 
Replace import collections to import collection.abc for Python >= 3.3

See issue #252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working not qualified The issue is not checked yet by the owners
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@metal3d