fix: send numbers or bools as payloads #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@retrohacker is master still our target for 6.x? I see the new middleware/routing system is targeted to land on next. |
DonutEspresso
force-pushed
the
send-zero-false
branch
from
510718e
to
69f709d
Compare
|
Sorry @hekike I had to remove your fancy variadic parsing - doesn't seem possible to disambiguate a bool payload from the format arg! |
hekike
reviewed
Feb 23, 2018
tools/mk/Makefile.targ
Outdated
| @@ -122,6 +122,10 @@ check-bash: $(BASH_FILES:%=%.bashchk) $(BASH_FILES:%=%.bashstyle) | |||
| %.bashstyle: % | |||
| $(BASHSTYLE) $^ | |||
|
|
|||
| .PHONY: check-eslint-fix | |||
There was a problem hiding this comment.
we have a make fix-style that reprints everything with prettier, probably more accurate than ESLint fix: https://github.com/restify/node-restify/blob/master/tools/mk/Makefile.targ#L137
There was a problem hiding this comment.
Oh nice! I completely forgot you added that! I'll remove this target 👍
hekike
approved these changes
Feb 23, 2018
3 tasks
This was referenced Apr 9, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1461 and #1607