breaking: support parsing of valid falsy json #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonutEspresso
commented
Jul 14, 2018
| // --- Tests | ||
|
|
||
| describe('restify-client tests', function () { | ||
|
|
||
| before(function (callback) { | ||
| try { | ||
| SERVER = restify.createServer({ | ||
| dtrace: dtrace, |
There was a problem hiding this comment.
7.x no longer takes dtrace as a function, it's now a boolean. Removed as it wasn't super important for the client tests.
|
Is that really a regression, it seems that the erroneous behavior may have been present for a while. For instance, the commit at fb52f48#diff-1f5c7c63b7ce8433f5b0480296a5f265R57 uses: to set the response object. Wouldn't that have the same problem? If so, that commit was merged ~2015, wouldn't that make this PR semver major? |
hekike
approved these changes
Jul 16, 2018
|
@misterdjules You're right - I confused this with restify's ability to send these values as strings (but not for restify-client's ability to parse those strings as valid JSON). I guess this is indeed semver major. |
DonutEspresso
changed the title
retrohacker
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of revving dependencies, I discovered a regression in JSONClient. I'm not sure when it happened, it looks like the tests were not even checking for the right thing.
Essentially, if the server sends 0, null, or false, that is valid JSON and the client should respect it. This is similar to restify/node-restify#1609.