fix: respect when status code is set with res.status (GH-1429)

[svozza]

Pre-Submission Checklist

• Opened an issue discussing these changes before opening the PR
• Ran the linter and tests via make prepush
• Included comprehensive and convincing tests for changes

Issues

Closes:

• Issue Setting the status code with res.status has no effect #1429

Changes

Before setting the default status code to 200 if there's been no error, it checks to see if res.status has been set and uses the value there if it has.

[kwhitley]

@svozza - is this PR required for the apicache release?

Also, huge thanks for spearheading this - I've been swamped!

[kwhitley]

Ahhh nm @svozza - have tested the fix myself, it works! 👍

Pretty please to the authors for a quick merge and npm patch for this... my users will be very grateful if I don't have to drop restify support to properly cover Node 7.7, 8+! :)

[kwhitley]

@svozza You see the out of date notice? Looks like a merge needed now...

[kwhitley]

@retrohacker, any idea on a merge & publish timeline on this? Apicache is waiting on a pretty big release that requires this fix!

🙏

[sean3z]

Thanks for submitting this @svozza! 👍

I'm unsure whether this route was the original intent coming out of #1377
However, since it does solve the issue, this seems to be the best solution until a more long-term fix can be put in place.

I'm surprised this test wasn't in place before now! 😛

[svozza]

Thank you, much appreciated! 😃