Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node support 7.7 #97

Merged
merged 26 commits into from Aug 17, 2017
Merged

Node support 7.7 #97

merged 26 commits into from Aug 17, 2017

Conversation

kwhitley
Copy link
Owner

@kwhitley kwhitley commented Aug 2, 2017

No description provided.

@coveralls
Copy link

coveralls commented Aug 2, 2017

Coverage Status

Changes Unknown when pulling 9c934ca on node-support-7.7 into ** on master**.

@kwhitley kwhitley mentioned this pull request Aug 9, 2017
@kwhitley
Copy link
Owner Author

kwhitley commented Aug 9, 2017

Release pending the following node-restify fix:
restify/node-restify#1429 (issue)
restify/node-restify#1440 (PR)

@kwhitley
Copy link
Owner Author

kwhitley commented Aug 9, 2017

The above fix should clear tests...

@kwhitley kwhitley mentioned this pull request Aug 9, 2017
@svozza
Copy link
Contributor

svozza commented Aug 15, 2017

So the Restify fix has been merged! We can either wait for v5.0.2 to drop or we can just reference the commit hash in our package.json.

@svozza
Copy link
Contributor

svozza commented Aug 15, 2017

So this is weird, all the tests on this branch are passing locally even though the latest version of Restify released on NPM is 5.1.0 from 5 days ago so my fix wouldn't be present there.

@kwhitley
Copy link
Owner Author

@svozza I definitely don't get that (passing tests). I implemented your fix locally to the project a week or so ago for continued local development while we wait, but as soon as I blew away my modules and reloaded (5.1.0) it failed again on the status codes.

@svozza
Copy link
Contributor

svozza commented Aug 15, 2017

Ah wait, my mistake, I hadn't deleted my node_modules; I had changed the Restify version in package.json to this beforehand:

...
"restify": "restify/node-restify#5abc06779df3b3ed4faf4d19f0815051a7c3106b",
...

The tests don't pass if I revert back ^5.0.1.

@kwhitley kwhitley mentioned this pull request Aug 15, 2017
@coveralls
Copy link

coveralls commented Aug 17, 2017

Coverage Status

Changes Unknown when pulling 37e85ca on node-support-7.7 into ** on master**.

@kwhitley kwhitley merged commit 4ae232b into master Aug 17, 2017
@kwhitley kwhitley deleted the node-support-7.7 branch August 23, 2017 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants