Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for PHP 8.3 and SF 7.X #198

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

jewome62
Copy link

@jewome62 jewome62 commented Mar 17, 2024

composer + lint + unit test OK

#190

@jewome62 jewome62 changed the title update libs for SF 7 Update for PHP 8.3 and SF 7.X Mar 17, 2024
@jewome62
Copy link
Author

unit test local is ok with new version and --prefer-lowest

@jewome62
Copy link
Author

@dsbilling if you want review (last contributor if you have any advice)
@cryptiklemur I can't do more i suppose so that's can be merged ?

@dsbilling
Copy link
Contributor

dsbilling commented Mar 17, 2024

@dsbilling if you want review (last contributor if you have any advice) @cryptiklemur I can't do more i suppose so that's can be merged ?

Adding monolog/monolog will revert changes done in #188 and #189, might want to fix that 👍🏻

@jewome62
Copy link
Author

@dsbilling if you want review (last contributor if you have any advice) @cryptiklemur I can't do more i suppose so that's can be merged ?

Adding monolog/monolog will revert changes done in #188 and #189, might want to fix that 👍🏻

Here i have added into require-dev, because it is required for the test.
add into required-dev just download when you develop on the lib, not when you use it on your project

@jewome62
Copy link
Author

@dsbilling I confirm, no problem with my change on my project.
It's not laravel, but API-Platform 3.2 (Symfony 7.0) with monolog 3.5 required.
No problem to install or on usage

{
     "repositories": {
        "jewome62_restcord": {
            "type": "vcs",
            "url": "git@github.com:jewome62/restcord.git"
        }
    },
    "require":{
        "restcord/restcord": "dev-feature/update-sf",
    }
}

Copy link

@pb-butcher pb-butcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants