Add Github Action to replace travis #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jewome62
changed the title
jewome62
commented
Mar 17, 2024
|
|
||
| $output->text('-> Fetching User'); | ||
| $user = $client->user->getUser(['user.id' => (int) $guild->owner_id]); | ||
| Assertion::eq(0001, $user->discriminator); | ||
| Assertion::eq('0000', $user->discriminator); |
There was a problem hiding this comment.
Discriminator is not used anymore, so default value = 0000
jewome62
commented
Mar 17, 2024
| "symfony/options-resolver": "^3.4|^4.4|^5.1|^6.0", | ||
| "psr/log": "^2.0|^3.0" | ||
| "symfony/options-resolver": "^3.4|^4.4|^5.1|^6.0|^7.0", | ||
| "psr/log": "^1.1|^2.0|^3.0" |
There was a problem hiding this comment.
need 1.X version because 2.0 and more need PHP 8.X
So if we not add 1.X version we can remove version 7.X of PHP support
|
@cryptiklemur I add that for validate my PR and the next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To validate #198 , i have replace inactive travis test by GHA (GitHub Action)
Need to setup into github action secret :
TOKEN
GUILD_ID
CHANNEL_ID
Here on my fork and my own test discord : jewome62#1
list of action done : https://github.com/jewome62/restcord/actions/runs/8315913821
Include #198 change, so need to be merge after #198