Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add highest-rated-comment feature #2108

Merged
merged 17 commits into from Jun 4, 2019
Merged

Add highest-rated-comment feature #2108

merged 17 commits into from Jun 4, 2019

Commits on Jun 1, 2019

  1. Add highest-rated-comment feature

    @lubien
    lubien committed Jun 1, 2019
    Copy the full SHA
    345082f View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @lubien
    lubien committed Jun 1, 2019
    Copy the full SHA
    08f0fa9 View commit details
    Browse the repository at this point in the history

  3. Implement requested changes

    @lubien
    lubien committed Jun 1, 2019
    Copy the full SHA
    5fc2860 View commit details
    Browse the repository at this point in the history

  4. Updates on highest-rated-comments 

    * Simplify template.
* Update CSS to fit the template changes.
* Update init signature.
* Remove $ from DOM variables.
* Minor implementation changes.
* Correct arrowDown SVG template.
    @lubien
    lubien committed Jun 1, 2019
    Copy the full SHA
    decb520 View commit details
    Browse the repository at this point in the history

  5. Add @lubien to CODEOWNERS 

    Feature: highest-rated-comment.tsx
    @lubien
    lubien committed Jun 1, 2019
    Copy the full SHA
    1884048 View commit details
    Browse the repository at this point in the history

  6. Update rgh-highest-rated-comment CSS 

    We need to force just the color since the original comment original CSS
takes precedence unless we do this.
    @lubien
    lubien committed Jun 1, 2019
    Copy the full SHA
    717f7e9 View commit details
    Browse the repository at this point in the history

  7. Simplify rgh-highest-rated-comment 

    * Oneliner CSS border.
* JSX render function directly in init.
* Remove Prop type.
* Simplify JSX.
    @lubien
    lubien committed Jun 1, 2019
    Copy the full SHA
    6c72057 View commit details
    Browse the repository at this point in the history

  8. Get avatar in one line

    @lubien
    lubien committed Jun 1, 2019
    Copy the full SHA
    3997338 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2019

  1. Drop extra class

    @fregante
    fregante committed Jun 2, 2019
    Copy the full SHA
    d119bb4 View commit details
    Browse the repository at this point in the history

  2. Fix position (it should be after the first one)

    @fregante
    fregante committed Jun 2, 2019
    Copy the full SHA
    ac16d82 View commit details
    Browse the repository at this point in the history

  3. Correctly highlight the comment

    @fregante
    fregante committed Jun 2, 2019
    Copy the full SHA
    8b71d45 View commit details
    Browse the repository at this point in the history

  4. Use 2px border and unset max-width

    @fregante
    fregante committed Jun 2, 2019
    Copy the full SHA
    b64d345 View commit details
    Browse the repository at this point in the history

  5. Change var name and order for readability

    @fregante
    fregante committed Jun 2, 2019
    Copy the full SHA
    84659d1 View commit details
    Browse the repository at this point in the history

  6. Update description and screenshot and mention in readme

    @fregante
    fregante committed Jun 2, 2019
    Copy the full SHA
    76ff18e View commit details
    Browse the repository at this point in the history

  7. Use 2px border and unset max-width /2

    @fregante
    fregante committed Jun 2, 2019
    Copy the full SHA
    24e1a33 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2019

  1. Don't show highest-rated-comment for closest ones

    @lubien
    lubien committed Jun 3, 2019
    Copy the full SHA
    f94a89d View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2019

  1. Drop comment counter in selector

    @fregante
    fregante committed Jun 4, 2019
    Copy the full SHA
    10b4f50 View commit details
    Browse the repository at this point in the history