Add highest-rated-comment feature
#2108
Conversation
|
I'm on it |
|
Done |
There was a problem hiding this comment.
Can you commit to maintain this feature going forward? For example, in case GitHub changes something that breaks it. We already have way too many features to maintain, so we need to find a way to make this sustainable.
If so, can you add a line to the CODEOWNERS file?
* Simplify template. * Update CSS to fit the template changes. * Update init signature. * Remove $ from DOM variables. * Minor implementation changes. * Correct arrowDown SVG template.
Feature: highest-rated-comment.tsx
|
Implemented and added to CODEOWNERS ;) |
We need to force just the color since the original comment original CSS takes precedence unless we do this.
* Oneliner CSS border. * JSX render function directly in init. * Remove Prop type. * Simplify JSX.
|
Done ;) |
|
New screenshot:
|
|
Can you find more threads where this can be tested? |
|
I tried to search for cases on the 5th+ comment but had no luck over some huge repos I went through. Most would be the first one. About the changes I can tackle monday if it's okay to you. Today I have to deal with some things first :) |
fregante
changed the title
highest-rated-comment feature
|
This is great and will definitely super useful! Thank you @lubien! 🥇 |
|
Oh. I was gonna do it when I came back home. Thanks for your help Glad to work with you and see you next time |
|
Really like this feature, makes reading long discussion pages significantly easier. However, sometimes the 'jump to comment' banner doesn't show, and so the first time a user of the extension sees the gold border, it isn't immediately obvious what the colour means (from this issue):
I had to look through the DOM to see what was adding the
Perhaps adding a badge on the comment (similar to the 'Contributor', 'Collaborator' and 'Author' badges) saying "Highest rated comment" would improve accessibility for new users? Something like this:
This suggestion might be more appropriate in a separate issue or PR - happy to create one if so. |
|
You can send a PR and let’s see how it looks. I don’t think it’s enough to make that connection “Orange = highest rated comment” however. We don’t add the linking banner when the comment appears near the top (within the first 5 comments) |
Closes #1898
Test
leafo/sticky-kit#201
facebook/react#13991
flutter/flutter#11609 has controversial comments
MrMEEE/bumblebee-Old-and-abbandoned#123