Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expo and React Native examples to CI #365

Merged
merged 8 commits into from Mar 11, 2024

Conversation

aryaemami59
Copy link
Contributor

@aryaemami59 aryaemami59 commented Feb 22, 2024

This PR:

  • Adds Expo and React Native examples to CI workflow.

Depends on #364

Copy link

codesandbox-ci bot commented Feb 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@timdorr
Copy link
Member

timdorr commented Feb 22, 2024

Honestly, this may be a bit of overkill for a 43 line, 1 file library 🙂

@timdorr
Copy link
Member

timdorr commented Mar 10, 2024

This adds another 9-10 minute test onto the suite. I appreciate the completeness, but that seems like total overkill. I'm closing this one out. Thanks nonetheless!

@timdorr timdorr closed this Mar 10, 2024
@aryaemami59 aryaemami59 deleted the add-rn-and-expo-to-ci branch March 10, 2024 03:59
@aryaemami59
Copy link
Contributor Author

@timdorr fair enough, I was just trying to stay consistent with the other repos.

@aryaemami59 aryaemami59 restored the add-rn-and-expo-to-ci branch March 11, 2024 17:52
@EskiMojo14 EskiMojo14 reopened this Mar 11, 2024
@aryaemami59
Copy link
Contributor Author

@timdorr I should add the same actions/cache usage to the CI here as well right?

@timdorr
Copy link
Member

timdorr commented Mar 11, 2024

Yeah, that helps a tiny bit with all the example build times.

Thanks!

@timdorr timdorr merged commit efd278b into reduxjs:master Mar 11, 2024
19 checks passed
@aryaemami59
Copy link
Contributor Author

@timdorr Thank you!

@aryaemami59 aryaemami59 deleted the add-rn-and-expo-to-ci branch March 11, 2024 18:39
aryaemami59 added a commit to aryaemami59/redux-thunk that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants