Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expo and React Native examples to CI #4681

Merged
merged 7 commits into from Mar 11, 2024

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Adds Expo and React Native examples to CI workflow.

Copy link

codesandbox-ci bot commented Feb 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

netlify bot commented Mar 10, 2024

Deploy Preview for redux-docs ready!

Name Link
🔨 Latest commit 629d600
🔍 Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/65ed2e0aa0b69b0008ef110e
😎 Deploy Preview https://deploy-preview-4681--redux-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@timdorr
Copy link
Member

timdorr commented Mar 10, 2024

Can we add any caching to this to speed things up? This slows the test suite by nearly 5x and this library isn't React-specific. This seems like overkill to me.

@aryaemami59
Copy link
Contributor Author

@timdorr Sure I can figure out some sort of caching to speed this up.

@timdorr
Copy link
Member

timdorr commented Mar 11, 2024

Updated the RN examples upstream to be much much faster, but also added a cache. Thanks for getting this together!

@timdorr timdorr merged commit 348c155 into reduxjs:master Mar 11, 2024
26 checks passed
@aryaemami59 aryaemami59 deleted the add-rn-and-expo-to-ci branch March 11, 2024 07:50
@aryaemami59
Copy link
Contributor Author

@timdorr

Updated the RN examples upstream to be much much faster, but also added a cache. Thanks for getting this together!

That's awesome, thank you Tim! This makes me wonder, would it be okay then to re-open reduxjs/redux-thunk#365?

@timdorr
Copy link
Member

timdorr commented Mar 11, 2024

Unfortunately, I can't reopen that PR (branch is deleted). But feel free to submit a new one and we'll get it merged in.

@aryaemami59
Copy link
Contributor Author

@timdorr Thank you!!!

@EskiMojo14
Copy link
Contributor

i reopened it 👍🏻

@aryaemami59
Copy link
Contributor Author

@EskiMojo14 Thank you Ben!

aryaemami59 added a commit to aryaemami59/redux that referenced this pull request Mar 21, 2024
Co-authored-by: Tim Dorr <timdorr@users.noreply.github.com>
Co-authored-by: Tim Dorr <git@timdorr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants