Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud API supplemental/how-to docs (control and data plane, overview) #411

Merged
merged 44 commits into from
May 17, 2024

Conversation

kbatuigas
Copy link
Collaborator

@kbatuigas kbatuigas commented Apr 10, 2024

Add new Cloud API docs to the RP Cloud docs: https://docs.redpanda.com/current/deploy/deployment-option/cloud/. These are "supplemental" docs to the API reference (PR here) and aim to provide more detailed steps and explanations on using the Cloud API.

Review deadline: 16 May 2024

NOTE: Adding the cloud API reference (i.e. the specs) is done in #283 since that has to be merged in the api branch where our API reference pages live. This PR is against the main branch, where our regular docs live and where we add non-reference (e.g. conceptual topics, or task-oriented docs) content.

Cloud API subsection under Deploy > Cloud: index page
Cloud API overview
Cloud API Authentication
Control Plane API
Data Plane APIs

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit b196634
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/6647dacfb5d8bd00085c9213
😎 Deploy Preview https://deploy-preview-411--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kbatuigas kbatuigas changed the title [DRAFT] cloud API how-to docs (control and data plane, overview) [DRAFT] cloud API supplemental docs (control and data plane, overview) Apr 23, 2024
modules/ROOT/nav.adoc Outdated Show resolved Hide resolved
@towfiqa towfiqa self-requested a review May 1, 2024 18:58

The Redpanda Admin API is a REST API to manage aspects of a Redpanda cluster. You can use the Admin API to perform operations that are specific to the Redpanda platform and cannot be done using the standard Kafka API.

Redpanda Cloud uses a control plane and data plane architecture. The *control plane* is where most cluster management, operations, and maintenance takes place. The control plane enforces rules in the data plane. The *data plane* is where your cloud cluster lives. The term _data plane_ is used interchangeably with _cluster_.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the section header and start the paragraph here. And everything above should be in the "Please Note:" block

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@towfiqa want to add a note here to say we could do this, but also wanted to show another option. I'll push up some commits shortly so that we get an updated preview and then you can let us know which one you prefer!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@towfiqa I changed the section header to "Cloud API architecture", removed the info about the other APIs and moved them over to the API and SDK reference index page. What do you think of this flow? Anything you prefer to see?

Copy link
Collaborator Author

@kbatuigas kbatuigas May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@towfiqa Right now, the reference overview (preview) is sharing the same content as on this page.

I have a more condensed overview that I drafted here, plus instructions on making requests from the reference page here, and a tiny quickstart here. Do you prefer these to be displayed on the reference page, instead of the content we have in the cloud-api-overview.adoc and cloud-api-authentication.adoc files?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@towfiqa I actually went ahead and replaced it with the "condensed" content. Let me know what you think.

@kbatuigas kbatuigas marked this pull request as ready for review May 4, 2024 01:01
@kbatuigas kbatuigas requested a review from a team as a code owner May 4, 2024 01:01
@kbatuigas kbatuigas mentioned this pull request May 7, 2024
2 tasks
@kbatuigas kbatuigas changed the title [DRAFT] cloud API supplemental docs (control and data plane, overview) Cloud API supplemental docs (control and data plane, overview) May 7, 2024
@@ -0,0 +1,138 @@
= Manage Cluster Resources Using the Cloud API
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need confirmation on whether this page title is okay, or if it should be reworded (is "cluster resources" accurate?)

To be able to use the Cloud API:

* You must be a customer with an existing organization in Redpanda Cloud.
* You can only use one organization for authentication. See xref:deploy:deployment-option/cloud/api/cloud-api-authentication.adoc[Cloud API Authentication] for steps to authenticate API requests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rephrase this a bit, e.g. to explain that a token is always for a specific organization. if they want to switch to a different organization, they must acquire a new token (with a service account from the other org)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@birdayz Added in this commit; please let me know if the change doesn't address this!

}' -X POST https://api.redpanda.com/v1beta2/clusters
----

The Create Cluster endpoint returns a <<long_running_operations,long-running operation>>. When the operation is completed, you can retrieve cluster details by calling xref:api:ROOT:cloud-api.adoc#get-/v1beta2/clusters/-id-[`GET /v1beta2/clusters/\{id}`], passing the cluster ID as a parameter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our regular docs, we use property instead of parameter.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micheleRP Ah, I think both property and parameter can be used in the API context, but parameter is the more common term for the "specific value you use in the API URL path" https://swagger.io/resources/articles/best-practices-in-api-design/


Create a network by making a request to xref:api:ROOT:cloud-api.adoc#post-/v1beta2/networks[`POST /v1beta2/networks`].

Choose a CIDR range that does not overlap with your existing VPCs or your Redpanda network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,139 @@
= Manage Cluster Resources Using the Cloud API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
= Manage Cluster Resources Using the Cloud API
= Use the Data Plane APIs

@micheleRP
Copy link
Contributor

@kbatuigas I have doubts about the page titles and descriptions:
Manage Clusters using the Cloud API
Use the Control Plane API to manage your clusters and organization-level resources in Redpanda Cloud.

Manage Cluster Resources Using the Cloud API
Use the Data Plane APIs to manage resources within your Redpanda Cloud clusters.

Suggest the following titles and descriptions instead:
= Use the Control Plane API
:description: Use the Control Plane API to manage resources in your Redpanda Cloud organization.
= Use the Data Plane APIs
:description: Use the Data Plane APIs to manage your Redpanda Cloud clusters.

@kbatuigas kbatuigas requested a review from micheleRP May 17, 2024 21:51
Comment on lines 59 to 60
- xref:deploy:deployment-option/cloud/dedicated/dedicated-tiers.adoc[Dedicated tiers and regions]
- xref:deploy:deployment-option/cloud/byoc-tiers.adoc[BYOC tiers and regions]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these now link to your tiers table in the API docs instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micheleRP good call, I'll make that change. Currently I am only able to link to an "api-description" anchor in the API reference (and we have kept it to the original GCP vs AWS tables), maybe that can be tweaked later.


Create a network by making a request to xref:api:ROOT:cloud-api.adoc#post-/v1beta2/networks[`POST /v1beta2/networks`].

Choose a xref:deploy/deployment-option/cloud/cidr-ranges.adoc[CIDR range] that does not overlap with your existing VPCs or your Redpanda network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Choose a xref:deploy/deployment-option/cloud/cidr-ranges.adoc[CIDR range] that does not overlap with your existing VPCs or your Redpanda network.
Choose a xref:deploy:deployment-option/cloud/cidr-ranges.adoc[CIDR range] that does not overlap with your existing VPCs or your Redpanda network.

Copy link
Contributor

@micheleRP micheleRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix the cidr link and review my other suggestions, then lgtm!

@kbatuigas kbatuigas merged commit 51370a8 into main May 17, 2024
5 checks passed
Deflaimun pushed a commit that referenced this pull request Jun 5, 2024
…#411)

Co-authored-by: JakeSCahill <jake@redpanda.com>
Co-authored-by: Michele Cyran <michele@redpanda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants