-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloud API specs #283
Add cloud API specs #283
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
local-antora-playbook.yml
Outdated
@@ -7,13 +7,13 @@ content: | |||
- url: . | |||
branches: HEAD | |||
- url: https://github.com/redpanda-data/documentation | |||
branches: [v/*, site-search, main, shared] | |||
branches: [v/*, site-search, cloud-api-docs-combined, shared] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this back to main
before merging. This is just here so we can test including content from that branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^ @kbatuigas Reminder - as I see this still reads main
…ng the API directly from the reference page
…equests from the reference doc
Thank you @mo-redpanda ! Let me address per item:
and also:
@mo-redpanda Can you provide guidance on how to make it clearer which response body to check, or which API call it is?
|
@towfiqa adding questions here -
Please also note that we can't add any more nav sections on the left hand side on top of "Redpanda Cloud," "API Servers," and "Authentication". This is a Rapidoc limitation. |
we must give it some name. it's used in openapi fields .security and components.securitySchemes. the name can be changed no problem, but it will have SOME name. See https://github.com/redpanda-data/cloudv2/blob/main/proto/gen/openapi/openapi.prod.yaml#L3550 and https://github.com/redpanda-data/cloudv2/blob/main/proto/gen/openapi/openapi.prod.yaml#L6647
Technically it can be moved. Is this the correct location? https://github.com/redpanda-data/cloudv2/blob/5461591ab003d593a17afc9e3a7a5f665ba96b08/proto/gen/openapi/openapi.prod.yaml#L5668 I find it problematic though, if we move it to CreateCluster. It's not just specific to the CreateCluster endpoint. Regions, zones apply to Network and Network Peering as well. Also, in the future, it is related to Cloud Storage Bucket resource as well. It's NOT just for clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to make the update at the top that Jake marked. Also make the updates re GUI elements per the Style Guide. Thx!
Co-authored-by: Joyce Fee <102751339+Feediver1@users.noreply.github.com>
Opened a PR in cloudv2 to edit the Regions description https://github.com/redpanda-data/cloudv2/pull/15391 |
Per Joyce's update to PM, we are releasing the cloud API docs so we can test the try-it functionality prior to the beta announcement. |
Deploy preview
Review deadline: 16 May 2024
NOTE: Adding the cloud API reference (i.e. the specs) are done in this PR since it has to be merged in the
api
branch where our API reference pages live. #411 is open against themain
branch, where our regular docs live and where we add non-reference (e.g. conceptual topics, or task-oriented docs) content.This PR also uses Rapidoc "slots" to inject custom HTML into the generated reference documentation. Currently, this only works for the overview and auth sections. The content added here has some overlap with the supplemental docs (added in #411 ) but is a condensed version, and more relevant to readers who might want to make API requests directly from the reference doc instead of programmatically.
The overview also contains a "how to use the API reference" and "quickstart" subsections
The overview lists error responses in one subsection
The Regions/Throughput tiers section in the overview needs the formatting fixed (@JakeSCahill to investigate).
There will be a fix to remove the text box next to the "Get Token" button