New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tooling for OCP 4.15; update base images #69
Conversation
I had some doubts w.r.t the version of kustomize that should be included in this PR, as the kustomize CLI binary is not included downstream (neither is Downstream, we only ship kustomize as a kubectl plugin (i.e. Thus, I'm under the impression the version of the kustomize binary we ship upstream is not dependant on the version of kubectl kustomize that we ship downstream. |
README.md
Outdated
- [rhoas](https://github.com/redhat-developer/app-services-cli) [v0.53.0](https://github.com/redhat-developer/app-services-cli/tree/v0.53.0) | ||
- [submariner](https://github.com/submariner-io/submariner) [v0.16.2](https://github.com/submariner-io/subctl/tree/v0.16.2) | ||
- [submariner](https://github.com/submariner-io/submariner) [v0.17.0](https://github.com/submariner-io/subctl/tree/v0.17.0) | ||
- [kubevirt](https://github.com/kubevirt/kubevirt) [v1.1.0](https://github.com/kubevirt/kubevirt/tree/v1.1.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checking, should kubevirt be updated as well? To kubevirt 1.2.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, seems like kubevirt was released as I was working on this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checked: WTO downstream uses the cnv-4.14-for-rhel-8-x86_64-rpms
repo for installing kubevirt (virtctl) and there doesn't seem to be a correspondance between the downstream version and upstream version: the version shipped in both upstream and dowstream are the latest available versions for each product.
For example, WTO 1.9 upstream uses kubevirt v1.10
and downstream uses v0.59.2-50-gfc77afd4e
.
Will update this PR accordingly.
Thank you for the review David :) I pushed the fixup commits for updating kubevirt to v1.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Thank you so much for the review @dkwon17 :) Merging 🎉 |
This PR updates the tooling used in the web terminal operator tooling container to their latest versions available on mirror.openshift.com and github releases for OCP 4.15, as well as updates the UBI8-minimal image used.
Testing
I've pushed the web terminal tooling container built from this PR to
quay.io/aobuchow/wto-tooling:1.10
for convenience.quay.io/aobuchow/wto-tooling:1.10
. Alternatively, create a web terminal with the default image and runwtoctl set image quay.io/aobuchow/wto-tooling:1.10
in the web terminal consoleoc version
should indicate version 4.15.