Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Is it tested? How?
Testing requires an OpenShift 4.15 cluster.
I've built the controller, index and bundle images from this PR and pushed them to
quay.io/aobuchow/wto-controller:1.10
,quay.io/aobuchow/wto-bundle:1.10
&quay.io/aobuchow/wto-index:1.10
respectively.The accompanying WTO tooling image (built from this PR) has also been pushed to
quay.io/aobuchow/wto-tooling:1.10
.To test the images, set the
WTO_IMG
,BUNDLE_IMG
&INDEX_IMG
environment variables to the above-mentioned repos, i.e:Then run
make install
from the root of this repo.WTO 1.10 should be installed (and viewable on the Installed Operators page of the OpenShift console) using the images built from this PR.
Note: Running the version of WTO installed will still be using
quay.io/wto/web-terminal-operator:next
instead of the image built from this PR, set toWTO_IMG
. To actually test out the controller image, find the web-terminal-operator clusterserviceversion in theopenshift-operators
namespace, and modify thespec.containers.image
field to use the controller image built from this PR. E.g.:The web-terminal-controller deployment should spawn a new pod with the updated container, and you should be able to create web terminals.
A future PR could automate this process of updating the CSV for testing the controller image (as this confused me a bit while working on this PR).