Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for WTO 1.10 release #157

Merged
merged 1 commit into from Mar 15, 2024
Merged

Conversation

AObuchow
Copy link
Collaborator

@AObuchow AObuchow commented Mar 6, 2024

What does this PR do?

Is it tested? How?

Testing requires an OpenShift 4.15 cluster.

I've built the controller, index and bundle images from this PR and pushed them to quay.io/aobuchow/wto-controller:1.10, quay.io/aobuchow/wto-bundle:1.10 & quay.io/aobuchow/wto-index:1.10 respectively.

The accompanying WTO tooling image (built from this PR) has also been pushed to quay.io/aobuchow/wto-tooling:1.10.

To test the images, set the WTO_IMG, BUNDLE_IMG & INDEX_IMG environment variables to the above-mentioned repos, i.e:

export WTO_IMG=quay.io/aobuchow/wto-controller:1.10 && export BUNDLE_IMG=quay.io/aobuchow/wto-bundle:1.10 && export INDEX_IMG=quay.io/aobuchow/wto-index:1.10

Then run make install from the root of this repo.

WTO 1.10 should be installed (and viewable on the Installed Operators page of the OpenShift console) using the images built from this PR.

Note: Running the version of WTO installed will still be using quay.io/wto/web-terminal-operator:next instead of the image built from this PR, set to WTO_IMG. To actually test out the controller image, find the web-terminal-operator clusterserviceversion in the openshift-operators namespace, and modify the spec.containers.image field to use the controller image built from this PR. E.g.:

apiVersion: operators.coreos.com/v1alpha1
kind: ClusterServiceVersion
(...)
spec:
(...)
  install:
    spec:
      deployments:
        - name: web-terminal-controller
          spec:
(...)
              spec:
                containers:
                  - env:
                      - name: POD_NAME
                        valueFrom:
                          fieldRef:
                            fieldPath: metadata.name
                      - name: OPERATOR_NAME
                        value: web-terminal-operator
                      - name: RELATED_IMAGE_web_terminal_tooling
                        value: 'quay.io/wto/web-terminal-tooling:latest'
                      - name: RELATED_IMAGE_web_terminal_exec
                        value: 'quay.io/eclipse/che-machine-exec:nightly'
-                   image: 'quay.io/wto/web-terminal-operator:next'
+                   image: 'quay.io/aobuchow/wto-controller:1.10'
                    imagePullPolicy: Always
                    name: web-terminal-controller
                    resources: {}
                serviceAccountName: web-terminal-controller

The web-terminal-controller deployment should spawn a new pod with the updated container, and you should be able to create web terminals.

A future PR could automate this process of updating the CSV for testing the controller image (as this confused me a bit while working on this PR).

@che-bot
Copy link

che-bot commented Mar 15, 2024

❌ E2E Happy path tests failed ❗

See Details

- Jenkins job - [

- Use comment "[wto-ci-test]" to rerun happy path E2E test.

CHANGELOG.md Outdated Show resolved Hide resolved
* Update changelog, CSV version
* Update base images for controller build
* Update minimum OpenShift version annotation

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
@AObuchow AObuchow merged commit e250481 into redhat-developer:main Mar 15, 2024
3 checks passed
@AObuchow AObuchow deleted the update-3.10 branch March 15, 2024 19:04
@che-bot
Copy link

che-bot commented Mar 15, 2024

❌ E2E Happy path tests failed ❗

See Details

- Jenkins job - [

- Use comment "[wto-ci-test]" to rerun happy path E2E test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants