Add variables for constant first-person model offset #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used to make the first-person weapon model less intrusive (or left-handed, although this isn't ideal as the model itself won't be mirrored).
qreeves
reviewed
Dec 29, 2021
There was a problem hiding this comment.
My only concern here is that the first person arms determine the muzzle location, and it would be possible to set them to a position that would pretty much allow a person to shoot around corners. The position may need to be constrained to the player's width, but I'm not certain if that is enough to mitigate the issue.
| trans.add(vec(dirforward).mul(firstpersondist)); | ||
| trans.add(vec(dirside).mul(firstpersonside)); | ||
| trans.add(vec(dirup).mul(firstpersonup)); | ||
| mdl.o.add(trans); |
There was a problem hiding this comment.
There's not much point to any of the intermediate vec's here.
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to make the first-person weapon model less intrusive (or left-handed, although this isn't ideal as the model itself won't be mirrored).
Preview
Various combinations of
/firstpersonside,/firstpersonupand/firstpersondist: