Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix louvain_communities, PropertyGraph, cudf column.full, dgl 2.1.0 CI failures #4215

Merged
merged 7 commits into from Mar 7, 2024

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Mar 5, 2024

  • Updates cudf usage in hypergraph to use cudf.core.column.as_column instead of the deprecated cudf.core.column.full API
  • Adds code to call louvain using a signature that's compatible with both pre and post NX 3.3
  • Adds an upper bound to the DGL version pin to ensure a compatible version is used
  • Updates a PropertyGraph test to handle minor ordering changes in the result DataFrame
  • Test matrices starting 24.04 have changed, resulting in an "empty matrix" error when attempting to use the supported combination used for PyG. Previously, we can only test PyG with CUDA 11.8 AND amd64. With CUDA 11.8 replaced with 12.2 in test matrix, we need to adapt cugraph-pyg's wheel test script to work with 12.2. As of now, we just skip the test to unblock CI. cc @tingyu66

@eriknw eriknw requested a review from a team as a code owner March 5, 2024 18:31
@github-actions github-actions bot added the python label Mar 5, 2024
@eriknw eriknw changed the title nx-cugraph: fix louvain_communities CI failure Fix louvain_communities and PropertyGraph CI failures Mar 5, 2024
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for fixing the PG test.

This brings up a question though: before NX 3.3 is released, should this recent change be updated to move the new max_level arg to the end of the nx.louvain_communities signature to not break other users possibly using position-only args?

@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change labels Mar 5, 2024
@rlratzel
Copy link
Contributor

rlratzel commented Mar 5, 2024

/merge

@eriknw eriknw changed the title Fix louvain_communities and PropertyGraph CI failures Fix louvain_communities, PropertyGraph, and cudf column.full CI failures Mar 5, 2024
@ChuckHastings
Copy link
Collaborator

/merge

@eriknw eriknw requested a review from a team as a code owner March 6, 2024 03:01
@github-actions github-actions bot added the ci label Mar 6, 2024
@eriknw eriknw changed the title Fix louvain_communities, PropertyGraph, and cudf column.full CI failures Fix louvain_communities, PropertyGraph, cudf column.full, dgl 2.1.0 CI failures Mar 6, 2024
@rapids-bot rapids-bot bot merged commit 5cfea53 into rapidsai:branch-24.04 Mar 7, 2024
136 of 141 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants