Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use as_column instead of full" #15235

Closed
wants to merge 2 commits into from

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Mar 5, 2024

Reverts #14698

That change is causing a number of issues downstream that we don't want to try to resolve right now.

@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Mar 5, 2024
@vyasr vyasr self-assigned this Mar 5, 2024
@vyasr vyasr requested review from a team as code owners March 5, 2024 22:37
@vyasr vyasr requested review from shwina and isVoid March 5, 2024 22:37
@github-actions github-actions bot added the cuDF (Python) Affects Python cuDF API. label Mar 5, 2024
@galipremsagar
Copy link
Contributor

/merge

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the style check fails due to copyright year ranges

python/cudf/cudf/utils/utils.py Outdated Show resolved Hide resolved
Co-authored-by: jakirkham <jakirkham@gmail.com>
@galipremsagar
Copy link
Contributor

galipremsagar commented Mar 5, 2024

/merge

@bdice bdice added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Mar 6, 2024
@bdice
Copy link
Contributor

bdice commented Mar 6, 2024

Blocking merge of this reversion: rapidsai/cugraph#4215 should fix the last known issue introduced by #14698.

Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking merge

@galipremsagar
Copy link
Contributor

Closing this as all dependent repos have been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - DO NOT MERGE Hold off on merging; see PR for details bug Something isn't working cuDF (Python) Affects Python cuDF API. non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants