More resilient pandoc self-contained mechanism #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
@jmcphers I think it's worth checking if we need a similar fix in the RStudio version of this function (although we can't necessarily rely on htmltools there): |
|
@jjallaire Appreciate the heads up, I've opened rstudio/rstudio#1756 to track this. |
3 tasks
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two pandoc 2.0 issues with
saveWidget(selfcontained=TRUE):[WARNING] This document format requires a nonempty <title> elementmessage from saveWidget doesn't specify a <title> element #289<!DOCTYPE html>showing up as a text string in the browser (though often hidden because many htmlwidgets completely fill the page)I tested with pandoc 2.0.2 and 1.19.2.1, both on Linux. They both seem to work fine with the examples I tried. However, one difference I noticed was that JavaScript dependencies are completely data URI/base64 encoded in 1.19.2.1, but inlined as cleartext in 2.0.2. I don't know if this matters to anyone, I actually think cleartext is superior personally.
pandoc 1.19.2.1:
pandoc 2.0.2: