Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbreak saveWidget( ... selfcontained = FALSE ...) #293

Merged
merged 2 commits into from Dec 6, 2017

Conversation

ThomasSiegmund
Copy link

#292 broke the selfcontained = FALSE case, writing only markdown without conversation to html. This restores the previous behaviour.

@jjallaire
Copy link
Collaborator

@jcheng5 Could you review this?

@jcheng5
Copy link
Collaborator

jcheng5 commented Dec 6, 2017

Ouch, sorry for introducing that bug! This looks good. Perhaps we should include the <title> in the self-contained=FALSE case as well. I think that should be as simple as html <- tagList(tags$head(tags$title(title)), html)?

@ThomasSiegmund
Copy link
Author

Good point, I have added the title

@jjallaire jjallaire merged commit c9a9684 into ramnathv:master Dec 6, 2017
@jcheng5
Copy link
Collaborator

jcheng5 commented Dec 6, 2017

Thanks @ThomasSiegmund!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants