Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android fix (Gboard) #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

omega1996
Copy link

fixes #40 and #170

I've taken the code snippet from #40 (comment).
thank to equilerex
hpierre74 also asked for this fix #40 (comment)

@omega1996 omega1996 changed the title android fix Android fix (Gboard) Apr 21, 2023
@simboel
Copy link

simboel commented Dec 29, 2023

@csculley can you please have a look at this?
I'm also affected by the problem that PR tries to fix.

@csculley
Copy link
Collaborator

csculley commented Jan 8, 2024

Sorry for the delay, but this PR looks to be our best and most minimal option at mitigating the issue without waiting for a fix to come from upstream in Quill or ideally Android...
I can't see Android keeping this behavior long term, it's so problematic, but who knows since the earliest report I've seen is from 2014....
wxik/react-native-rich-editor#208 (comment) contains even more references to this problem 😭

@simboel
Copy link

simboel commented Jan 20, 2024

@csculley I've implemented the fix in my application and found that there are some edge cases. I will validate this and provide an updated version of this PR.

One problem is for example that changes to attributes (i.e. data- attributes) will simply delete the mention blot completely.
But I fixed these and need a little bit more time to prepare the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete fail on mobile
3 participants