Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show correct commit in quarto check install #9526

Merged
merged 7 commits into from
May 28, 2024
Merged

Show correct commit in quarto check install #9526

merged 7 commits into from
May 28, 2024

Commits on May 28, 2024

  1. Correctly run git rev-parse in quarto-cli repo. 

    Otherwise, the commit shown was the one of the project from which `quarto check` was run, or another if no .git in this project.
    @cderv
    cderv committed May 28, 2024
    Configuration menu
    Copy the full SHA
    75f3887 View commit details
    Browse the repository at this point in the history

  2. Fix path if QUARTO_ROOT unset

    @cderv
    cderv committed May 28, 2024
    Configuration menu
    Copy the full SHA
    7b64c65 View commit details
    Browse the repository at this point in the history

  3. Also set QUARTO_DEBUG true for interactive debugging in VSCODE

    @cderv
    cderv committed May 28, 2024
    Configuration menu
    Copy the full SHA
    65c20f3 View commit details
    Browse the repository at this point in the history

  4. QUARTO_ROOT can be unset in some of our runs

    @cderv
    cderv committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a2d56ae View commit details
    Browse the repository at this point in the history

  5. Revert "QUARTO_ROOT can be unset in some of our runs" 

    This reverts commit cf14684.

Just to check if QUARTO_ROOT was unset or just this was a type check issue
    @cderv
    cderv committed May 28, 2024
    Configuration menu
    Copy the full SHA
    42b8eeb View commit details
    Browse the repository at this point in the history

  6. Does this also trigger the TS check issue ?

    @cderv
    cderv committed May 28, 2024
    Configuration menu
    Copy the full SHA
    3273cb1 View commit details
    Browse the repository at this point in the history

  7. Use kIndent everywhere to ensure same spacing in checks

    @cderv
    cderv committed May 28, 2024
    Configuration menu
    Copy the full SHA
    b9becf9 View commit details
    Browse the repository at this point in the history