Show correct commit in quarto check install
#9526
Open
+16
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the commit shown was the one of the project from which `quarto check` was run, or another if no .git in this project.
cderv
commented
Apr 29, 2024
src/command/check/check.ts
Outdated
| }); | ||
| if (gitHead.stdout) { | ||
| info(` commit: ${gitHead.stdout.trim()}`); | ||
| if (Deno.env.get("QUARTO_ROOT")) { |
There was a problem hiding this comment.
In other places we do join(quartoConfig.sharePath(), "../..") and do not assume QUARTO_ROOT is set.
Though it seems better to assume it is, at least it should from interactive run of quarto check from a dev version
There was a problem hiding this comment.
And it seems I should do the same here, because QUARTO_ROOT is not set in our every run !
There was a problem hiding this comment.
And it seems I should do the same here, because
QUARTO_ROOTis not set in our every run !
Do we understand why QUARTO_ROOT is not set?
This reverts commit cf14684. Just to check if QUARTO_ROOT was unset or just this was a type check issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly run
git rev-parsein quarto-cli repo.Otherwise, the commit shown was the one of the project from which
quarto checkwas run, or another if no .git in this project.Follow up on #9145