New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name scale properties on Sprites to things that make sense #2021
Open
DigiDuncan
wants to merge
8
commits into
pythonarcade:development
Choose a base branch
from
DigiDuncan:scale_prop_name_fix
base: development
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Name scale properties on Sprites to things that make sense #2021
DigiDuncan
wants to merge
8
commits into
pythonarcade:development
from
DigiDuncan:scale_prop_name_fix
+127
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR: This will be a non-breaking change & efficiency upgrade with pyglet 2.1, which seems to be coming sooner than expected. Benefits:
Steps required:
|
8 tasks
What about the initializer? Should |
Imo, it could be either without an if hasattr(scale, "__len__"):
self._scale = Vec2(*scale)
else:
self._scale = Vec2(scale, scale) |
DigiDuncan
force-pushed
the
scale_prop_name_fix
branch
from
April 16, 2024 06:25
4b94361
to
d62528d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
scale
to afloat
for backwards compatible codefeel/easy proportional scalingscale
returns atuple[float, float]
scale
->scale_x
scale_xy
->scale
scale_y
Why should this be done?
scale
as it is returnsscale_x
, which is incorrect if x/y are scaled independently.Sprite
currently returnsposition
¹ as a 2-tuple, andcenter_x
andcenter_y
as floats.scale
in both dimensions, and Arcade should aim to provide transferable knowledge..scale
returns x,scale_y
returns y,scale_xy
returns a tuple, but settingscale
sets both x and y, is very confusing and makes code harder to read and reeks havoc on codefeel.¹I'd argue
position
should becenter
as well, but that's for another day.