New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Camera2D in arcade's top level namespace #2055
base: development
Are you sure you want to change the base?
Expose Camera2D in arcade's top level namespace #2055
Conversation
Good idea. We have other "core" objects exposed (Text, Window, View, Sprite) and this makes sense to have. You want more complex cameras, dig into |
c7a991e
to
2623830
Compare
It does make sense historically, but I'm a little bit conflicted here. Should we not try to slim down the arcade module when possible? It already contains so much. |
I would say our most important objects (and most accessible ones) should be top-level. Camera2D, Text, Window, View, Sprite, Sound, etc. The more advanced or specialized versions (PerspectiveProjector, or BasicSprite, etc.) can be accessed in their sub-modules. |
@einarf
The current custom viewport options for
I think we should flip
|
2623830
to
58bdfcd
Compare
The recent commits pushed:
|
Might also be a good idea to update imports in examples here? |
Yep. I think this might wait till after the following:
From what I remember of trying to test something like this locally, it also caused some havoc when trying to build doc in certain cases. That may have been due to trying to squeeze cameras into the current doc build system clumsily and in a rush. I'll revisit this PR in the coming days after the above. |
Maybe we should just merge this quick to at least get the |
TL;DR: It might actually be very broken despite tests seeming to pass. I haven't it recently and so I don't remember the details, but there was at some point a wall of red in build output related to this. From what I remember:
I was going to wait until the following are in place:
|
Changes
TL;DR: Enable
arcade.Camera2D
andfrom arcade import Camera2D
Camera2D
+ supporting classes toarcade/__init__.py
Camera2D
+ supporting classes toarcade.__all__
Why