Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] gh-116417: Move limited C API tests to _testlimitedcapi #116567

Closed
wants to merge 11 commits into from
Closed

[WIP] gh-116417: Move limited C API tests to _testlimitedcapi #116567

wants to merge 11 commits into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 10, 2024 •
edited by bedevere-app bot

PR to show how it can look alike to move most tests on the limited C API from _testcapi extension to the new _testlimitedcapi extension.

@vstinner
pythongh-116417: Move limited C API tests to _testlimitedcapi
3b01457 
* Move bytes.c and sys.c from Modules/_testcapi/ to
  Modules/_testlimitedcapi/.
* Split some tests in two files, limited and non-limited:

  * abstract.c
  * dict.c
  * list.c
  * set.c

* Copy util.h to Modules/_testlimitedcapi/.
* Update test_capi.
@vstinner
unicode.c
5761f80
@vstinner
lower Py_LIMITED_API
2c984f6
@vstinner
long.c
0354b84
@vstinner
AC: don't use PyFloat_AS_DOUBLE() with limited C API
916dc57
@vstinner
float.c
422c188
@bedevere-app bedevere-app bot mentioned this pull request Mar 10, 2024
Closed
@vstinner
Copy link
Member Author

This PR creates 9 files in Modules/_testlimitedcapi/:

  • abstract.c
  • bytearray.c
  • bytes.c
  • dict.c
  • float.c
  • list.c
  • long.c
  • set.c
  • unicode.c

@vstinner vstinner mentioned this pull request Mar 11, 2024
Merged
@vstinner vstinner closed this Mar 19, 2024
@vstinner vstinner deleted the testlimitedcapi_move branch March 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum will be requested when the pull request is marked ready for review gvanrossum is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vstinner