New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pymepack binding for gem #2166
base: main
Are you sure you want to change the base?
pymepack binding for gem #2166
Conversation
… for pymepack lyapunov solvers
…lyapunov solvers to use with pymepack binding
Mirroring external branch in external_pr_2166 |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a quick glance, everything necessary to use pymepack seems to be here. The question is how to test it in CI. How do you install pymepack? For the CI, it would be nice if it was possible to install pymepack using pip
from PyPI (i.e., pip install pymepack
).
src/pymor/algorithms/lyapunov.py
Outdated
# This file is part of the pyMOR project (https://www.pymor.org). | ||
# Copyright pyMOR developers and contributors. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pymepack-0.9.1-cp38-cp38-manylinux_2_31_x86_64.zip
@pmli , please, use this wheel to pip install the pymepack project.
[pymepack-0.9.1-cp38-cp38-linux_x86_64.zip](https://github.com/pymor/pymor/files/12474200/pymepack-0.9.1-cp38-cp38-linux_x86_64.zip)
Please, change the extension to .whl and use pip install to install pymepack
For some reason, I got the above comment by email, but I don't see it in this thread. But, anyway, installing from PyPI would be nicer, but I guess installing from URL could also work in CI.
|
@pmli , the wheel w/o dependencies, so I deleted the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the pymepack tests pass. However, as I said, it would be good for us to have wheels on PyPI for all Python versions from 3.8 to 3.11.
@pmli , the PR is ready for review, pymepack is available at PyPI: https://pypi.org/project/pymepack/ |
This pull request modifies make ci_requirements and commit the changed files to ensure that CI runs with the updated dependencies. |
I tried updating the requirements, but running
@sdrave, any ideas? |
No idea why the error message has to be so bad and I don't understand what dune-xt hast to do with it. But |
This pull request modifies make ci_requirements and commit the changed files to ensure that CI runs with the updated dependencies. |
The CI failures seem due to the fact that the pymepack wheel has been compiled for a newer numpy than the one we test with. For binary wheels it is generally a good idea to depend on oldest-supported-numpy. I'm not sure whether this issue can be resolved before hard freeze. |
True. Let's postpone this. |
This PR adds a binding to python-mepack (pymepack) backend lyapunov solvers.
The binding offers the option for iterative refinement and shows better performance when compared to slycot.
NOTE: branch for this pull request is based on the branch for #2167 in the forked project.