Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example and test for Kriging interpolation #132

Merged
merged 12 commits into from Oct 5, 2023

Conversation

cchwala
Copy link
Contributor

@cchwala cchwala commented Oct 5, 2023

As stated here the kriging code is not covered in tests, even though it might look like it is tested based on the name of the test... 🙈

In this PR I will

  • add a test for Kriging
  • add an example notebook for spatial interpolation where Kriging is used
  • unpin scipy and pandas (this is included here because I branched from removed pinning of scipy and pandas #131 which is still open, but can be closed in favor of this PR here)

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (700c768) 73.25% compared to head (708771f) 74.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   73.25%   74.53%   +1.27%     
==========================================
  Files          29       29              
  Lines        1077     1084       +7     
==========================================
+ Hits          789      808      +19     
+ Misses        288      276      -12     
Flag Coverage Δ
unittests 74.53% <100.00%> (+1.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pycomlink/spatial/interpolator.py 91.11% <100.00%> (+15.20%) ⬆️
setup.py 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cchwala cchwala merged commit df08da4 into pycomlink:master Oct 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant